linux-kernel - Re: [PATCH] mwifiex: duplicate static structs used in driver instances

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZrXdgIJe6U4sJJwU@pengutronix.de>
Date: Fri, 9 Aug 2024 11:12:32 +0200
From: Sascha Hauer <s.hauer@...gutronix.de>
To: Ping-Ke Shih <pkshih@...ltek.com>
Cc: Brian Norris <briannorris@...omium.org>,
	Francesco Dolcini <francesco@...cini.it>,
	Kalle Valo <kvalo@...nel.org>,
	Yogesh Ashok Powar <yogeshp@...vell.com>,
	Bing Zhao <bzhao@...vell.com>,
	"John W. Linville" <linville@...driver.com>,
	Amitkumar Karwar <akarwar@...vell.com>,
	Avinash Patil <patila@...vell.com>,
	Kiran Divekar <dkiran@...vell.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH] mwifiex: duplicate static structs used in driver
 instances

On Fri, Aug 09, 2024 at 08:49:32AM +0000, Ping-Ke Shih wrote:
> Sascha Hauer <s.hauer@...gutronix.de> wrote:
> > +       wiphy->bands[NL80211_BAND_2GHZ] = devm_kmemdup(adapter->dev,
> > +                                                      &mwifiex_band_2ghz,
> > +                                                      sizeof(mwifiex_band_2ghz),
> > +                                                      GFP_KERNEL);
> 
> It seems like you forget to free the duplicate memory somewhere?

It's freed automatically when adapter->dev is released, see the various
devm_* functions

Sascha


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |