[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <57f11aff-95f8-41fd-b35e-a9e5a85c68e3@suse.de>
Date: Fri, 9 Aug 2024 12:53:05 +0300
From: Stanimir Varbanov <svarbanov@...e.de>
To: Jim Quinlan <james.quinlan@...adcom.com>, linux-pci@...r.kernel.org,
Nicolas Saenz Julienne <nsaenz@...nel.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
Cyril Brulebois <kibi@...ian.org>, Stanimir Varbanov <svarbanov@...e.de>,
Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
Krzysztof Kozlowski <krzk@...nel.org>,
bcm-kernel-feedback-list@...adcom.com, jim2101024@...il.com
Cc: Florian Fainelli <florian.fainelli@...adcom.com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Krzysztof WilczyĆski <kw@...ux.com>,
Rob Herring <robh@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@...ts.infradead.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@...ts.infradead.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 05/12] PCI: brcmstb: Use swinit reset if available
Hi Jim,
On 8/1/24 01:28, Jim Quinlan wrote:
> The 7712 SOC adds a software init reset device for the PCIe HW.
> If found in the DT node, use it.
>
> Signed-off-by: Jim Quinlan <james.quinlan@...adcom.com>
> ---
> drivers/pci/controller/pcie-brcmstb.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
> index 4d68fe318178..948fd4d176bc 100644
> --- a/drivers/pci/controller/pcie-brcmstb.c
> +++ b/drivers/pci/controller/pcie-brcmstb.c
> @@ -266,6 +266,7 @@ struct brcm_pcie {
> struct reset_control *rescal;
> struct reset_control *perst_reset;
> struct reset_control *bridge_reset;
> + struct reset_control *swinit_reset;
> int num_memc;
> u64 memc_size[PCIE_BRCM_MAX_MEMC];
> u32 hw_rev;
> @@ -1633,12 +1634,30 @@ static int brcm_pcie_probe(struct platform_device *pdev)
> if (IS_ERR(pcie->bridge_reset))
> return PTR_ERR(pcie->bridge_reset);
>
> + pcie->swinit_reset = devm_reset_control_get_optional_exclusive(&pdev->dev, "swinit");
> + if (IS_ERR(pcie->swinit_reset))
> + return PTR_ERR(pcie->swinit_reset);
> +
> ret = clk_prepare_enable(pcie->clk);
> if (ret)
> return dev_err_probe(&pdev->dev, ret, "could not enable clock\n");
>
> pcie->bridge_sw_init_set(pcie, 0);
>
> + if (pcie->swinit_reset) {
> + ret = reset_control_assert(pcie->swinit_reset);
> + if (dev_err_probe(&pdev->dev, ret, "could not assert reset 'swinit'\n"))
> + goto clk_disable_unprepare;
> +
> + /* HW team recommends 1us for proper sync and propagation of reset */
> + udelay(1);
Hmm, shouldn't this delay be part of .assert/.deassert reset_control
driver? I think this detail is reset-control hw specific and the
consumers does not need to know it.
> +
> + ret = reset_control_deassert(pcie->swinit_reset);
> + if (dev_err_probe(&pdev->dev, ret,
> + "could not de-assert reset 'swinit' after asserting\n"))
> + goto clk_disable_unprepare;
> + }
> +
> ret = reset_control_reset(pcie->rescal);
> if (dev_err_probe(&pdev->dev, ret, "failed to deassert 'rescal'\n"))
> goto clk_disable_unprepare;
~Stan
Powered by blists - more mailing lists