linux-kernel - Re: [PATCH v2 1/3] dt-bindings: serial: Add Loongson UART controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5fdf6810-f729-42bf-a5fd-a2de02d0a894@kernel.org>
Date: Fri, 9 Aug 2024 12:05:38 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: 郑豪威 <zhenghaowei@...ngson.cn>,
 gregkh@...uxfoundation.org, jirislaby@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, chenhuacai@...nel.org,
 kernel@...0n.name, p.zabel@...gutronix.de
Cc: linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, loongarch@...ts.linux.dev
Subject: Re: [PATCH v2 1/3] dt-bindings: serial: Add Loongson UART controller

On 09/08/2024 11:55, 郑豪威 wrote:
>>
>>>>> +    description: Enables fractional-N division. Currently,
>>>>> +      only LS2K1500 and LS2K2000 support this feature.
>>>>> +
>>>>> +  rts-invert:
>>>>> +    description: Inverts the RTS value in the MCR register.
>>>>> +      This should be used on Loongson-3 series CPUs, Loongson-2K
>>>>> +      series CPUs, and Loongson LS7A bridge chips.
>>>>> +
>>>>> +  dtr-invert:
>>>>> +    description: Inverts the DTR value in the MCR register.
>>>>> +      This should be used on Loongson-3 series CPUs, Loongson-2K
>>>>> +      series CPUs, and Loongson LS7A bridge chips.
>>>>> +
>>>>> +  cts-invert:
>>>>> +    description: Inverts the CTS value in the MSR register.
>>>>> +      This should be used on Loongson-2K0500, Loongson-2K1000,
>>>>> +      and Loongson LS7A bridge chips.
>>>>> +
>>>>> +  dsr-invert:
>>>>> +    description: Inverts the DSR value in the MSR register.
>>>>> +      This should be used on Loongson-2K0500, Loongson-2K1000,
>>>>> +      and Loongson LS7A bridge chips.
>> Same questions for all these. Why choosing invert is a board level
>> decision? If it "should be used" then why it is not used always?
>>
> Because these features are not applicable to all chips, such as 
> 'fractional-division',

Hm?

> 
> which is currently supported only by 2K1500 and 2K2000, and for 
> Loongson-3 series

These are SoCs. Compatible defines that. Please align with your
colleagues, because *we talked about this* already.

Best regards,
Krzysztof