[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZrXslA1c-BhO6zYr@ashyti-mobl2.lan>
Date: Fri, 9 Aug 2024 11:16:52 +0100
From: Andi Shyti <andi.shyti@...ux.intel.com>
To: "Nilawar, Badal" <badal.nilawar@...el.com>
Cc: Raag Jadav <raag.jadav@...el.com>, jani.nikula@...ux.intel.com,
joonas.lahtinen@...ux.intel.com, rodrigo.vivi@...el.com,
tursulin@...ulin.net, airlied@...il.com, daniel@...ll.ch,
linux@...ck-us.net, andi.shyti@...ux.intel.com,
intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
anshuman.gupta@...el.com, riana.tauro@...el.com,
ashutosh.dixit@...el.com, karthik.poosa@...el.com,
andriy.shevchenko@...ux.intel.com
Subject: Re: [PATCH v4] drm/i915/hwmon: expose fan speed
Hi Badal,
> > +static int
> > +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val)
> > +{
> > + struct i915_hwmon *hwmon = ddat->hwmon;
> > + struct hwm_fan_info *fi = &ddat->fi;
> > + u32 reg_val, pulses, time, time_now;
> > + intel_wakeref_t wakeref;
> > + long rotations;
> > + int ret = 0;
> > +
> > + if (attr != hwmon_fan_input)
> > + return -EOPNOTSUPP;
> Using a switch case in rev3 is more logical here. It will also simplify
> adding more fan attributes in the future. This is why switch cases are used
> in other parts of the file.
it was my suggestion and to be honest I would rather prefer it
this way. I can understand it if we were expecting more cases in
the immediate, like it was in your case.
But I wouldn't have an ugly and unreadable one-case-switch in the
eventuality that something comes in the future. In that case, we
can always convert it.
Thanks,
Andi
Powered by blists - more mailing lists