linux-kernel - Re: [PATCH] mptcp: correct MPTCP_SUBFLOW_ATTR_SSN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c78f98ff-df44-475f-bb1c-5c33f816ee11@kernel.org>
Date: Fri, 9 Aug 2024 12:42:19 +0200
From: Matthieu Baerts <matttbe@...nel.org>
To: Eugene Syromiatnikov <esyr@...hat.com>, mptcp@...ts.linux.dev
Cc: Mat Martineau <martineau@...nel.org>, Geliang Tang <geliang@...nel.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Davide Caratti <dcaratti@...hat.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mptcp: correct MPTCP_SUBFLOW_ATTR_SSN_OFFSET reserved
 size

Hi Eugene,

On 09/08/2024 11:43, Eugene Syromiatnikov wrote:
> ssn_offset field is u32 and is placed into the netlink response with
> nla_put_u32(), but only 2 bytes are reserved for the attribute payload
> in subflow_get_info_size() (even though it makes no difference in the end,
> as it is aligned up to 4 bytes).  Supply the correct argument to the relevant
> nla_total_size() call to make it less confusing.

Good catch, thank you for sharing this patch!

The modification in the code and the description look good to me!

Please note that when you submit a patch to the Netdev mailing list, the
subject should have the 'PATCH net' prefix (or net-next) as mentioned in
the Netdev doc:

  https://docs.kernel.org/process/maintainer-netdev.html

> Fixes: 5147dfb5083204d6 ("mptcp: allow dumping subflow context to userspace")

Checkpatch is complaining about this line, because the commit ID should
have 12 chars:

https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

Note that checkpatch.pl also points out the fact that the lines in the
commit description should have max 75 chars -- ideally 72 -- which is
not the case above with the line ending with 'relevant'.

Do you mind sending a v2 with these small fixes, so your patch can be
directly applied in the net tree, please?

(Do not forget to wait 24h between two versions as mentioned in the doc)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.