linux-kernel - RE: [PATCH v2 2/2] iio: imu: smi240: imu driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AM8PR10MB47217E50E6A7E20DC5C89973CDBA2@AM8PR10MB4721.EURPRD10.PROD.OUTLOOK.COM>
Date: Fri, 9 Aug 2024 12:18:21 +0000
From: "Shen Jianping (ME-SE/EAD2)" <jianping.shen@...bosch.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
CC: "Lorenz Christian (ME-SE/EAD2)" <Christian.Lorenz3@...bosch.com>, "Dolde
 Kai (ME-SE/PAE-A3)" <Kai.Dolde@...bosch.com>, "Frauendorf Ulrike (ME/PJ-SW3)"
	<Ulrike.Frauendorf@...bosch.com>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "dima.fedrau@...il.com"
	<dima.fedrau@...il.com>, "jic23@...nel.org" <jic23@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "lars@...afoo.de"
	<lars@...afoo.de>, "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"marcelo.schmitt1@...il.com" <marcelo.schmitt1@...il.com>, "robh@...nel.org"
	<robh@...nel.org>
Subject: RE: [PATCH v2 2/2] iio: imu: smi240: imu driver

Hi Christophe,

....
> +
> +	data = iio_priv(indio_dev);
> +	dev_set_drvdata(dev, indio_dev);
> +	data->regmap = regmap;
> +	data->capture = 0;

No need to explicitly initialize 'capture', devm_iio_device_alloc() already zeroes the allocated emmory.
It doesn't hurt to be explicit, but why this field and not the other ones?

-> This is the flag to enable capture mode. It is important to be disabled by default, therefore rather make this explicitly.

...

Jianping