linux-kernel - Re: [PATCH 1/2] PCI: Correct error reporting with PCIe failed link retraining

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2408091142330.61955@angie.orcam.me.uk>
Date: Fri, 9 Aug 2024 14:30:52 +0100 (BST)
From: "Maciej W. Rozycki" <macro@...am.me.uk>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
cc: Bjorn Helgaas <bhelgaas@...gle.com>, 
    Mika Westerberg <mika.westerberg@...ux.intel.com>, 
    linux-pci@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] PCI: Correct error reporting with PCIe failed link
 retraining

On Mon, 12 Feb 2024, Ilpo Järvinen wrote:

> > Only return successful completion status from `pcie_failed_link_retrain' 
> > if retraining has actually been done, preventing excessive delays from 
> > being triggered at call sites in a hope that communication will finally 
> > be established with the downstream device where in fact nothing has been 
> > done about the link in question that would justify such a hope.
> > 
> > Fixes: a89c82249c37 ("PCI: Work around PCIe link training failures")
> > Reported-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> > Link: https://lore.kernel.org/r/aa2d1c4e-9961-d54a-00c7-ddf8e858a9b0@linux.intel.com/
> > Signed-off-by: Maciej W. Rozycki <macro@...am.me.uk>
> > Cc: stable@...r.kernel.org # v6.5+
> 
> Thanks.
> 
> The original thread might be useful for context if somebody has to look at 
> this change later on from the history, so:
> 
> Link: https://lore.kernel.org/linux-pci/20240129112710.2852-2-ilpo.jarvinen@linux.intel.com/T/#u

 This refers the same thread of discussion as the link already included 
(and also is not a permalink), so I chose not to duplicate it in v2.

> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

 Thank you (also for the other change)!

 New series posted: 
<https://patchwork.kernel.org/project/linux-pci/list/?series=878216>.

  Maciej