linux-kernel - Re: [PATCH v2 2/2] iio: adc: ad7173: add support for ad4113

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7b032190f3009dfac9ef88c972362b9dc0f6ead5.camel@gmail.com>
Date: Fri, 09 Aug 2024 16:12:12 +0200
From: Nuno Sá <noname.nuno@...il.com>
To: "Ceclan, Dumitru" <mitrutzceclan@...il.com>, dumitru.ceclan@...log.com, 
 Lars-Peter Clausen
	 <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, 
 Jonathan Cameron
	 <jic23@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
	 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: ad7173: add support for ad4113

On Fri, 2024-08-09 at 15:32 +0300, Ceclan, Dumitru wrote:
> On 09/08/2024 15:26, Nuno Sá wrote:
> > On Fri, 2024-08-09 at 13:33 +0300, Dumitru Ceclan via B4 Relay wrote:
> > > From: Dumitru Ceclan <dumitru.ceclan@...log.com>
> > > 
> > > This commit adds support for the AD4113 ADC.
> > > The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital
> > > converter (ADC) that integrates an analog front end (AFE) for four
> > > fully differential or eight single-ended inputs.
> > > 
> > > Signed-off-by: Dumitru Ceclan <dumitru.ceclan@...log.com>
> > > ---
> > 
> > Any reason to drop my tag :)? There a b4 command that can help you with it.
> > 
> > - Nuno Sá
> > 
> > 
> 
> Yes, I added a new field to the device info struct and changed dt parsing
> because I missed in V1 that this model actually has a 16 bit data register.
> I considered that the rb would not apply anymore and it would need a re-review.
> 
> Thanks for the b4 suggestion but this was intentional :))

Got it. Next time mention that in the cover...

Reviewed-by: Nuno Sa <nuno.sa@...log.com>