linux-kernel - [PATCH v2 5.10/5.15] wifi: mac80211: apply mcast rate only if interface is up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20240809143122.534704-1-dutyrok@altlinux.org>
Date: Fri,  9 Aug 2024 17:31:22 +0300
From: Alexandr Shashkin <dutyrok@...linux.org>
To: linux-kernel@...r.kernel.org
Cc: Alexandr Shashkin <dutyrok@...linux.org>,
	stable@...r.kernel.org,
	lvc-project@...uxtesting.org,
	Johannes Berg <johannes@...solutions.net>,
	"David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	kovalev@...linux.org,
	syzbot+de87c09cc7b964ea2e23@...kaller.appspotmail.com,
	Johannes Berg <johannes.berg@...el.com>,
	Alexander Ofitserov <oficerovas@...linux.org>
Subject: [PATCH v2 5.10/5.15] wifi: mac80211: apply mcast rate only if interface is up

[ Upstream commit 02c665f048a439c0d58cc45334c94634bd7c18e6 ]

If the interface isn't enabled, don't apply multicast
rate changes immediately.

Reported-by: syzbot+de87c09cc7b964ea2e23@...kaller.appspotmail.com
Signed-off-by: Johannes Berg <johannes.berg@...el.com>
[oficerovas: Backported to 5.10 and 5.15]
Signed-off-by: Alexander Ofitserov <oficerovas@...linux.org>
Signed-off-by: Alexandr Shashkin <dutyrok@...linux.org>
---
Changes in v2:
- edit comment of oficerovas and add upstream commit
---
 net/mac80211/cfg.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
index 0c3da7771b48..13ac16026129 100644
--- a/net/mac80211/cfg.c
+++ b/net/mac80211/cfg.c
@@ -2560,7 +2560,8 @@ static int ieee80211_set_mcast_rate(struct wiphy *wiphy, struct net_device *dev,
 	memcpy(sdata->vif.bss_conf.mcast_rate, rate,
 	       sizeof(int) * NUM_NL80211_BANDS);
 
-	ieee80211_bss_info_change_notify(sdata, BSS_CHANGED_MCAST_RATE);
+	if (ieee80211_sdata_running(sdata))
+		ieee80211_bss_info_change_notify(sdata, BSS_CHANGED_MCAST_RATE);
 
 	return 0;
 }
-- 
2.42.2