[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240809144229.1370-1-ende.tan@starfivetech.com>
Date: Fri, 9 Aug 2024 22:42:29 +0800
From: Tan En De <endeneer@...il.com>
To: netdev@...r.kernel.org
Cc: alexandre.torgue@...s.st.com,
joabreu@...opsys.com,
davem@...emloft.net,
edumazet@...gle.com,
kuba@...nel.org,
pabeni@...hat.com,
mcoquelin.stm32@...il.com,
linux-kernel@...r.kernel.org,
leyfoon.tan@...rfivetech.com,
Tan En De <ende.tan@...rfivetech.com>
Subject: [net,1/1] net: stmmac: Set OWN bit last in dwmac4_set_rx_owner()
Ensure that all other bits in the RDES3 descriptor are configured before
transferring ownership of the descriptor to DMA via the OWN bit.
Signed-off-by: Tan En De <ende.tan@...rfivetech.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
index 1c5802e0d7f4..95aea6ad485b 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
@@ -186,10 +186,13 @@ static void dwmac4_set_tx_owner(struct dma_desc *p)
static void dwmac4_set_rx_owner(struct dma_desc *p, int disable_rx_ic)
{
- p->des3 |= cpu_to_le32(RDES3_OWN | RDES3_BUFFER1_VALID_ADDR);
+ p->des3 |= cpu_to_le32(RDES3_BUFFER1_VALID_ADDR);
if (!disable_rx_ic)
p->des3 |= cpu_to_le32(RDES3_INT_ON_COMPLETION_EN);
+
+ dma_wmb();
+ p->des3 |= cpu_to_le32(RDES3_OWN);
}
static int dwmac4_get_tx_ls(struct dma_desc *p)
--
2.34.1
Powered by blists - more mailing lists