linux-kernel - Re: [PATCH] fs: don't overwrite the nsec field if I_CTIME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240809-ausrollen-halsschlagader-02e0126179bc@brauner>
Date: Fri, 9 Aug 2024 16:55:26 +0200
From: Christian Brauner <brauner@...nel.org>
To: Jeff Layton <jlayton@...nel.org>
Cc: Alexander Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>, 
	Mateusz Guzik <mjguzik@...il.com>, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: don't overwrite the nsec field if I_CTIME_QUERIED is
 already set

On Fri, Aug 09, 2024 at 09:39:43AM GMT, Jeff Layton wrote:
> When fetching the ctime's nsec value for a stat-like operation, do a
> simple fetch first and avoid the atomic_fetch_or if the flag is already
> set.
> 
> Suggested-by: Mateusz Guzik <mjguzik@...il.com>
> Signed-off-by: Jeff Layton <jlayton@...nel.org>
> ---
> I'm running tests on this now, but I don't expect any problems.
> 
> This is based on top of Christian's vfs.mgtime branch. It may be best to
> squash this into 6feb43ecdd8e ("fs: add infrastructure for multigrain
> timestamps").

Squashed it. Can you double-check that things look correct?