[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240809-constant-oxidize-8aed145179c7@spud>
Date: Fri, 9 Aug 2024 15:59:58 +0100
From: Conor Dooley <conor@...nel.org>
To: Detlev Casanova <detlev.casanova@...labora.com>
Cc: linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Heiko Stuebner <heiko@...ech.de>,
Ulf Hansson <ulf.hansson@...aro.org>,
Finley Xiao <finley.xiao@...k-chips.com>,
Jagan Teki <jagan@...eble.ai>, Arnd Bergmann <arnd@...db.de>,
Elaine Zhang <zhangqing@...k-chips.com>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-pm@...r.kernel.org,
kernel@...labora.com
Subject: Re: [PATCH v2 1/2] dt-bindings: power: Add support for RK3576 SoC
On Thu, Aug 08, 2024 at 12:31:04PM -0400, Detlev Casanova wrote:
> From: Finley Xiao <finley.xiao@...k-chips.com>
>
> Define power domain IDs as described in the TRM and add compatible for
> rockchip,rk3576-power-controller
>
> Signed-off-by: Finley Xiao <finley.xiao@...k-chips.com>
> [reword, add yaml]
To be honest, both here and in your other patch, you should remove this
[] section and add a co-develop-ed-by instead.
Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> Signed-off-by: Detlev Casanova <detlev.casanova@...labora.com>
> ---
> .../power/rockchip,power-controller.yaml | 1 +
> .../dt-bindings/power/rockchip,rk3576-power.h | 30 +++++++++++++++++++
> 2 files changed, 31 insertions(+)
> create mode 100644 include/dt-bindings/power/rockchip,rk3576-power.h
>
> diff --git a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> index 0d5e999a58f1b..650dc0aae6f51 100644
> --- a/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> +++ b/Documentation/devicetree/bindings/power/rockchip,power-controller.yaml
> @@ -41,6 +41,7 @@ properties:
> - rockchip,rk3368-power-controller
> - rockchip,rk3399-power-controller
> - rockchip,rk3568-power-controller
> + - rockchip,rk3576-power-controller
> - rockchip,rk3588-power-controller
> - rockchip,rv1126-power-controller
>
> diff --git a/include/dt-bindings/power/rockchip,rk3576-power.h b/include/dt-bindings/power/rockchip,rk3576-power.h
> new file mode 100644
> index 0000000000000..324a056aa8512
> --- /dev/null
> +++ b/include/dt-bindings/power/rockchip,rk3576-power.h
> @@ -0,0 +1,30 @@
> +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
> +#ifndef __DT_BINDINGS_POWER_RK3576_POWER_H__
> +#define __DT_BINDINGS_POWER_RK3576_POWER_H__
> +
> +/* VD_NPU */
> +#define RK3576_PD_NPU 0
> +#define RK3576_PD_NPUTOP 1
> +#define RK3576_PD_NPU0 2
> +#define RK3576_PD_NPU1 3
> +
> +/* VD_GPU */
> +#define RK3576_PD_GPU 4
> +
> +/* VD_LOGIC */
> +#define RK3576_PD_NVM 5
> +#define RK3576_PD_SDGMAC 6
> +#define RK3576_PD_USB 7
> +#define RK3576_PD_PHP 8
> +#define RK3576_PD_SUBPHP 9
> +#define RK3576_PD_AUDIO 10
> +#define RK3576_PD_VEPU0 11
> +#define RK3576_PD_VEPU1 12
> +#define RK3576_PD_VPU 13
> +#define RK3576_PD_VDEC 14
> +#define RK3576_PD_VI 15
> +#define RK3576_PD_VO0 16
> +#define RK3576_PD_VO1 17
> +#define RK3576_PD_VOP 18
> +
> +#endif
> --
> 2.46.0
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists