linux-kernel - Re: [PATCH v2] vfs: Don't evict inode under the inode lru traversing context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240809-neuanfang-recyceln-b3d99596e98f@brauner>
Date: Fri,  9 Aug 2024 17:15:36 +0200
From: Christian Brauner <brauner@...nel.org>
To: Zhihao Cheng <chengzhihao@...weicloud.com>
Cc: Christian Brauner <brauner@...nel.org>,
	linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-ext4@...r.kernel.org,
	linux-mtd@...ts.infradead.org,
	chengzhihao1@...wei.com,
	yi.zhang@...wei.com,
	wangzhaolong1@...wei.com,
	yangerkun@...wei.com,
	mjguzik@...il.com,
	viro@...iv.linux.org.uk,
	error27@...il.com,
	tahsin@...gle.com,
	rydercoding@...mail.com,
	jack@...e.cz,
	hch@...radead.org,
	andreas.dilger@...el.com,
	tytso@....edu,
	richard@....at
Subject: Re: [PATCH v2] vfs: Don't evict inode under the inode lru traversing context

On Fri, 09 Aug 2024 11:16:28 +0800, Zhihao Cheng wrote:
> The inode reclaiming process(See function prune_icache_sb) collects all
> reclaimable inodes and mark them with I_FREEING flag at first, at that
> time, other processes will be stuck if they try getting these inodes
> (See function find_inode_fast), then the reclaiming process destroy the
> inodes by function dispose_list(). Some filesystems(eg. ext4 with
> ea_inode feature, ubifs with xattr) may do inode lookup in the inode
> evicting callback function, if the inode lookup is operated under the
> inode lru traversing context, deadlock problems may happen.
> 
> [...]

I've replaced the BUG_ON() with WARN_ON().

---

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/1] vfs: Don't evict inode under the inode lru traversing context
      https://git.kernel.org/vfs/vfs/c/24b0ba4e047d