linux-kernel - Re: [PATCH v3 2/3] iio: pressure: Add driver for Sensirion SDP500

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZrY1s5fYdC3hMxjj@smile.fi.intel.com>
Date: Fri, 9 Aug 2024 18:28:51 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: pd.pstoykov@...il.com
Cc: linux-iio@...r.kernel.org, Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/3] iio: pressure: Add driver for Sensirion SDP500

On Tue, Jul 02, 2024 at 04:59:09PM +0200, Petar Stoykov via B4 Relay wrote:
> From: Petar Stoykov <pd.pstoykov@...il.com>
> 
> Sensirion SDP500 is a digital differential pressure sensor. The sensor is
> accessed over I2C.

...

+ array_size.h
+ bits.h
+ dev_printk.h
+ errno.h

> +#include <linux/i2c.h>
> +#include <linux/crc8.h>
> +#include <linux/iio/iio.h>

+ mod_devicetable.h
+ module.h

> +#include <linux/regulator/consumer.h>

+ types.h

Keep them ordered, also you may split iio/ group out

> +#include <asm/unaligned.h>

linux/*
...blank line...
asm/*
...blank line...
iio/*

...

> +struct sdp500_data {
> +	struct device *dev;
> +};

Why is this structure needed at all? You may put dev pointer directly, no?

-- 
With Best Regards,
Andy Shevchenko