linux-kernel - Re: [PATCH v3 3/3] mm/migrate: move common code to numa_migrate_check (was numa_migrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17597d58-7da8-4555-b583-1997d78be018@redhat.com>
Date: Fri, 9 Aug 2024 17:32:43 +0200
From: David Hildenbrand <david@...hat.com>
To: Zi Yan <ziy@...dia.com>, linux-mm@...ck.org
Cc: Andrew Morton <akpm@...ux-foundation.org>,
 "Huang, Ying" <ying.huang@...el.com>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>,
 Kefeng Wang <wangkefeng.wang@...wei.com>, Yang Shi <shy828301@...il.com>,
 Mel Gorman <mgorman@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] mm/migrate: move common code to numa_migrate_check
 (was numa_migrate_prep)

On 09.08.24 16:59, Zi Yan wrote:
> do_numa_page() and do_huge_pmd_numa_page() share a lot of common code. To
> reduce redundancy, move common code to numa_migrate_prep() and rename
> the function to numa_migrate_check() to reflect its functionality.
> 
> Now do_huge_pmd_numa_page() also checks shared folios to set TNF_SHARED
> flag.

Yeah, I was also wondering why we didn't check that in the PMD case.

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb