linux-kernel - Re: [PATCH] ASoC: ak4458: remove "reset-gpios" property handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZrY3YZrvsua5DErC@smile.fi.intel.com>
Date: Fri, 9 Aug 2024 18:36:01 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Shengjiu Wang <shengjiu.wang@....com>
Cc: lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz, tiwai@...e.com,
	ckeepax@...nsource.cirrus.com, heiko@...ech.de, robh@...nel.org,
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
	shengjiu.wang@...il.com
Subject: Re: [PATCH] ASoC: ak4458: remove "reset-gpios" property handler

On Wed, Jul 03, 2024 at 08:26:15PM +0800, Shengjiu Wang wrote:
> commit c721f189e89c0 ("reset: Instantiate reset GPIO controller for
> shared reset-gpios") check if there is no "resets" property
> will fallback to "reset-gpios".
> 
> So don't need to handle "reset-gpios" separately in the driver,
> the "reset-gpios" handler is duplicated with "resets" control handler,
> remove it.

...

> -	if (ak4458->reset_gpiod) {
> -		gpiod_set_value_cansleep(ak4458->reset_gpiod, active);
> -		usleep_range(1000, 2000);
> -	} else if (!IS_ERR_OR_NULL(ak4458->reset)) {
> +	if (!IS_ERR_OR_NULL(ak4458->reset)) {

_OR_NULL is redundant.

>  		if (active)
>  			reset_control_assert(ak4458->reset);
>  		else

-- 
With Best Regards,
Andy Shevchenko