linux-kernel - Re: [PATCH v1] Namespace: Optimize the namespace code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8734ncu5c0.ffs@tglx>
Date: Sat, 10 Aug 2024 10:53:19 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Xavier <xavier_qy@....com>, anna-maria@...utronix.de,
 frederic@...nel.org, j.granados@...sung.com, linux@...ssschuh.net,
 mcgrof@...nel.org, kees@...nel.org
Cc: linux-kernel@...r.kernel.org, Xavier <xavier_qy@....com>
Subject: Re: [PATCH v1] Namespace: Optimize the namespace code

On Fri, Aug 09 2024 at 20:17, Xavier wrote:
> Modify variable names in the function clone_time_ns to enhance
> readability, and optimize the memory release operation by placing
> it outside of the spin lock in alloc_ucounts.

Renaming variables is not an optimization. Don't do two things at once.

Also the rename is not adding any value. This code is about time
namespace so 'ns' is perfectly understandable.

Thanks,

        tglx