linux-kernel - Re: [PATCH] x86/mm: remove unused CR3_HW_ASID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJD7tkaJKhoq6djbYBAiGiyjoSa+Jwcj1iNcLocgVfxwo3V43w@mail.gmail.com>
Date: Fri, 9 Aug 2024 18:10:12 -0700
From: Yosry Ahmed <yosryahmed@...gle.com>
To: x86@...nel.org, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>
Cc: Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, 
	"H. Peter Anvin" <hpa@...or.com>, Andy Lutomirski <luto@...nel.org>, Peter Zijlstra <peterz@...radead.org>, 
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, 
	Rick Edgecombe <rick.p.edgecombe@...el.com>, Andrew Morton <akpm@...ux-foundation.org>, 
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/mm: remove unused CR3_HW_ASID_BITS

On Thu, Apr 25, 2024 at 2:59 PM Yosry Ahmed <yosryahmed@...gle.com> wrote:
>
> Commit 6fd166aae78c ("x86/mm: Use/Fix PCID to optimize user/kernel
> switches") removed the last usage of CR3_HW_ASID_BITS and opted to use
> X86_CR3_PCID_BITS instead. Remove CR3_HW_ASID_BITS.
>
> Signed-off-by: Yosry Ahmed <yosryahmed@...gle.com>

I think this may have gotten lost in the noise, friendly ping :)

> ---
>  arch/x86/mm/tlb.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
> index 44ac64f3a047c..a2ba5bb201705 100644
> --- a/arch/x86/mm/tlb.c
> +++ b/arch/x86/mm/tlb.c
> @@ -85,9 +85,6 @@
>   *
>   */
>
> -/* There are 12 bits of space for ASIDS in CR3 */
> -#define CR3_HW_ASID_BITS               12
> -
>  /*
>   * When enabled, MITIGATION_PAGE_TABLE_ISOLATION consumes a single bit for
>   * user/kernel switches
> --
> 2.44.0.769.g3c40516874-goog
>