linux-kernel - Re: [PATCH 1/2] selftests: rust: config: add trailing newline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72kM1RsZCrK-3gFZufgeZQRvOBAbO=DwRHpukX5W=T=UAg@mail.gmail.com>
Date: Sat, 10 Aug 2024 12:33:32 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Anders Roxell <anders.roxell@...aro.org>
Cc: ojeda@...nel.org, alex.gaynor@...il.com, wedsonaf@...il.com, 
	shuah@...nel.org, rust-for-linux@...r.kernel.org, 
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] selftests: rust: config: add trailing newline

On Fri, Aug 2, 2024 at 2:45 PM Anders Roxell <anders.roxell@...aro.org> wrote:
>
> If adding multiple config files to the merge_config.sh script and
> rust/config is the fist one, then the last config fragment in this file
> and the first config fragment in the second file wont be set, since
> there isn't a newline in this file, so those two fragements end up at
> the same row like:
> CONFIG_SAMPLE_RUST_PRINT=mCONFIG_FRAGMENT=y
>
> And non of those will be enabled when running 'olddefconfig' after.
>
> Fixing the issue by adding a newline to the file.

Could `merge_config.sh` be improved too?

Shuah, if you plan to pick this:

Acked-by: Miguel Ojeda <ojeda@...nel.org>

Thanks!

Cheers,
Miguel