linux-kernel - Re: [PATCH v2 3/3] platform/surface: Add OF support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d01c19a3-dc76-46f5-bca4-f5fdc7bd8798@gmail.com>
Date: Sat, 10 Aug 2024 13:21:41 +0200
From: Konrad Dybcio <konradybcio@...il.com>
To: Maximilian Luz <luzmaximilian@...il.com>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, "Rafael J. Wysocki" <rafael@...nel.org>,
 Len Brown <lenb@...nel.org>, Hans de Goede <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Marijn Suijten <marijn.suijten@...ainline.org>,
 linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, linux-acpi@...r.kernel.org,
 platform-driver-x86@...r.kernel.org, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <quic_kdybcio@...cinc.com>
Subject: Re: [PATCH v2 3/3] platform/surface: Add OF support

On 10.08.2024 3:47 AM, Maximilian Luz wrote:
> On 8/10/24 3:28 AM, Konrad Dybcio wrote:
>> From: Konrad Dybcio <quic_kdybcio@...cinc.com>
> 
> [...]
> 
>> @@ -299,7 +302,7 @@ static const struct attribute_group ssam_sam_group = {
>>   };
>>     -/* -- ACPI based device setup. ---------------------------------------------- */
>> +/* -- Serial device setup. ------------------------------------------------- */
> 
> One more :)

Right, cursor at 80 != 80-long :P

[...]

> Are these two changes required? Surface 3 power and SAN should AFAIK be
> fairly "legacy" and ACPI-only drivers, which I don't expect to be used
> on any of the new ARM devices (apart from there probably being other
> changes required to make them work with DT).
> 
> I think with that addressed, it should be fine. I'll give it a spin
> tomorrow and send in my r-b and t-b (assuming everything goes well).

No, I went overly defensive here. Will drop for v3 next week.

Konrad