linux-kernel - Re: [PATCH 2/6] kbuild: rust: make command for `RUSTC_VERSION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=o7cRR909Q_Umr_Ssg5ZKhTXna5J2Nh-_goTGm4ssF-w@mail.gmail.com>
Date: Sat, 10 Aug 2024 13:37:32 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Wedson Almeida Filho <wedsonaf@...il.com>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...sung.com>, 
	Alice Ryhl <aliceryhl@...gle.com>, rust-for-linux@...r.kernel.org, 
	Nathan Chancellor <nathan@...nel.org>, Nicolas Schier <nicolas@...sle.eu>, linux-kbuild@...r.kernel.org, 
	linux-kernel@...r.kernel.org, patches@...ts.linux.dev
Subject: Re: [PATCH 2/6] kbuild: rust: make command for `RUSTC_VERSION_TEXT`
 closer to the `CC` one

On Fri, Aug 9, 2024 at 7:53 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> Even if "rustc --version" starts to print multiple lines,
> it will not cause an immediate problem.
>
> $(shell ... ) (both Makefile and Kconfig) replaces a new line
> with a space.
>
> CONFIG_RUSTC_VERSION_TEXT is not broken in any way.
> It would be just longer than we would expect.

+1, I will update the commit message when I apply it (or if you prefer
a v2 if you are taking it, or if you want to drop this commit, please
let me know!).

Thanks for taking a look, Masahiro.

Cheers,
Miguel