linux-kernel - Re: [PATCH v5 1/3] mm: don't account memmap on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <073C55C4-927C-4942-AFF1-E2D9D039F138@linux.dev>
Date: Sat, 10 Aug 2024 10:39:35 +0800
From: Muchun Song <muchun.song@...ux.dev>
To: Pasha Tatashin <pasha.tatashin@...een.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Linux Memory Management List <linux-mm@...ck.org>,
 linux-cxl@...r.kernel.org,
 cerasuolodomenico@...il.com,
 Johannes Weiner <hannes@...xchg.org>,
 Joel Granados <j.granados@...sung.com>,
 lizhijian@...itsu.com,
 Nhat Pham <nphamcs@...il.com>,
 David Rientjes <rientjes@...gle.com>,
 Mike Rapoport <rppt@...nel.org>,
 Sourav Panda <souravpanda@...gle.com>,
 Vlastimil Babka <vbabka@...e.cz>,
 Matthew Wilcox <willy@...radead.org>,
 Dan Williams <dan.j.williams@...el.com>,
 yi.zhang@...hat.com,
 alison.schofield@...el.com,
 David Hildenbrand <david@...hat.com>,
 Yosry Ahmed <yosryahmed@...gle.com>
Subject: Re: [PATCH v5 1/3] mm: don't account memmap on failure



> On Aug 10, 2024, at 03:10, Pasha Tatashin <pasha.tatashin@...een.com> wrote:
> 
> When we fail to allocate the mmemmap in alloc_vmemmap_page_list(), do
> not account any already-allocated pages: we're going to free all them
> before we return from the function.
> 
> Fixes: 15995a352474 ("mm: report per-page metadata information")
> Signed-off-by: Pasha Tatashin <pasha.tatashin@...een.com>
> Reviewed-by: Fan Ni <fan.ni@...sung.com>
> Reviewed-by: Yosry Ahmed <yosryahmed@...gle.com>
> Acked-by: David Hildenbrand <david@...hat.com>

Reviewed-by: Muchun Song <muchun.song@...ux.dev>