linux-kernel - Re: [PATCH v2] HID: hidraw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202408101044.nmAzxQqQ-lkp@intel.com>
Date: Sat, 10 Aug 2024 11:14:53 +0800
From: kernel test robot <lkp@...el.com>
To: Peter Hutterer <peter.hutterer@...-t.net>,
	Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] HID: hidraw - add HIDIOCREVOKE ioctl

Hi Peter,

kernel test robot noticed the following build warnings:

[auto build test WARNING on hid/for-next]
[also build test WARNING on linus/master v6.11-rc2 next-20240809]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Peter-Hutterer/HID-hidraw-add-HIDIOCREVOKE-ioctl/20240809-202833
base:   https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next
patch link:    https://lore.kernel.org/r/20240809100342.GA52163%40quokka
patch subject: [PATCH v2] HID: hidraw - add HIDIOCREVOKE ioctl
config: x86_64-randconfig-102-20240809 (https://download.01.org/0day-ci/archive/20240810/202408101044.nmAzxQqQ-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240810/202408101044.nmAzxQqQ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408101044.nmAzxQqQ-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/hid/hidraw.c:41:22: warning: no previous prototype for function 'hidraw_is_revoked' [-Wmissing-prototypes]
      41 | __weak noinline bool hidraw_is_revoked(struct hidraw_list *list)
         |                      ^
   drivers/hid/hidraw.c:41:17: note: declare 'static' if the function is not intended to be used outside of this translation unit
      41 | __weak noinline bool hidraw_is_revoked(struct hidraw_list *list)
         |                 ^
         |                 static 
>> drivers/hid/hidraw.c:47:21: warning: no previous prototype for function 'hidraw_open_errno' [-Wmissing-prototypes]
      47 | __weak noinline int hidraw_open_errno(__u32 major, __u32 minor)
         |                     ^
   drivers/hid/hidraw.c:47:17: note: declare 'static' if the function is not intended to be used outside of this translation unit
      47 | __weak noinline int hidraw_open_errno(__u32 major, __u32 minor)
         |                 ^
         |                 static 
   2 warnings generated.


vim +/hidraw_is_revoked +41 drivers/hid/hidraw.c

    40	
  > 41	__weak noinline bool hidraw_is_revoked(struct hidraw_list *list)
    42	{
    43		return list->revoked;
    44	}
    45	ALLOW_ERROR_INJECTION(hidraw_is_revoked, TRUE);
    46	
  > 47	__weak noinline int hidraw_open_errno(__u32 major, __u32 minor)
    48	{
    49		return 0;
    50	}
    51	ALLOW_ERROR_INJECTION(hidraw_open_errno, ERRNO);
    52	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki