linux-kernel - Re: [PATCH for-next 0/3] RDMA: Provide an API for drivers to disassociate mmap pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240811081846.GA448562@unreal>
Date: Sun, 11 Aug 2024 11:18:46 +0300
From: Leon Romanovsky <leon@...nel.org>
To: jgg@...pe.ca, Junxian Huang <huangjunxian6@...ilicon.com>
Cc: linux-rdma@...r.kernel.org, linuxarm@...wei.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH for-next 0/3] RDMA: Provide an API for drivers to
 disassociate mmap pages

On Mon, Aug 05, 2024 at 02:00:36PM +0300, Leon Romanovsky wrote:
> 
> On Fri, 26 Jul 2024 15:19:07 +0800, Junxian Huang wrote:
> > Provide an API rdma_user_mmap_disassociate() for drivers to disassociate
> > mmap pages. Use this API in hns to prevent userspace from ringing doorbell
> > when HW is reset.
> > 
> > Chengchang Tang (3):
> >   RDMA/core: Provide rdma_user_mmap_disassociate() to disassociate mmap
> >     pages
> >   RDMA/hns: Link all uctx to uctx_list on a device
> >   RDMA/hns: Disassociate mmap pages for all uctx when HW is being reset
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/3] RDMA/core: Provide rdma_user_mmap_disassociate() to disassociate mmap pages
>       https://git.kernel.org/rdma/rdma/c/29df39ce0a64f0

Junxian, sorry but I had to drop this series from my wip branch,

The more kbuilds reports I got the more I realized that this series
needs more work.

My main concern is that in first patch, you put uverbs_user_mmap_disassociate() function in
ib_core_verbs.c, which is not the right place for it. This function should stay in uverbs_main.c
which is protected by right "depends on" in Kconfig.

Please fix this and resend the series.

Thanks

> [2/3] RDMA/hns: Link all uctx to uctx_list on a device
>       https://git.kernel.org/rdma/rdma/c/bb5b2b25624fa9
> [3/3] RDMA/hns: Disassociate mmap pages for all uctx when HW is being reset
>       https://git.kernel.org/rdma/rdma/c/e60457876e3223
> 
> Best regards,
> -- 
> Leon Romanovsky <leon@...nel.org>
>