linux-kernel - Re: [PATCH] riscv: Make riscv_isa_vendor_ext

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2171ee94-ec78-4146-b6fa-9aecbb99efd8@ghiti.fr>
Date: Sun, 11 Aug 2024 10:21:41 +0200
From: Alexandre Ghiti <alex@...ti.fr>
To: Charlie Jenkins <charlie@...osinc.com>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>
Cc: linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
 kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] riscv: Make riscv_isa_vendor_ext_andes array static

Hi Charlie,

On 08/08/2024 02:27, Charlie Jenkins wrote:
> Since this array is only used in this file, it should be static.
>
> Signed-off-by: Charlie Jenkins <charlie@...osinc.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202407241530.ej5SVgX1-lkp@intel.com/
> ---
>   arch/riscv/kernel/vendor_extensions/andes.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/vendor_extensions/andes.c b/arch/riscv/kernel/vendor_extensions/andes.c
> index ec688c88456a..51f302b6d503 100644
> --- a/arch/riscv/kernel/vendor_extensions/andes.c
> +++ b/arch/riscv/kernel/vendor_extensions/andes.c
> @@ -8,7 +8,7 @@
>   #include <linux/types.h>
>   
>   /* All Andes vendor extensions supported in Linux */
> -const struct riscv_isa_ext_data riscv_isa_vendor_ext_andes[] = {
> +static const struct riscv_isa_ext_data riscv_isa_vendor_ext_andes[] = {
>   	__RISCV_ISA_EXT_DATA(xandespmu, RISCV_ISA_VENDOR_EXT_XANDESPMU),
>   };
>   
>
> ---
> base-commit: 8400291e289ee6b2bf9779ff1c83a291501f017b
> change-id: 20240807-make_andes_static-ec524bae21f2


Reviewed-by: Alexandre Ghiti <alexghiti@...osinc.com>

Thanks,

Alex