linux-kernel - Re: [syzbot] [net?] [virt?] BUG: stack guard page was hit in vsock_bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240811001341.2890-1-hdanton@sina.com>
Date: Sun, 11 Aug 2024 08:13:41 +0800
From: Hillf Danton <hdanton@...a.com>
To: syzbot <syzbot+bdb4bd87b5e22058e2a4@...kaller.appspotmail.com>
Cc: linux-kernel@...r.kernel.org,
	syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [net?] [virt?] BUG: stack guard page was hit in vsock_bpf_recvmsg

On Fri, 09 Aug 2024 10:42:21 -0700
> syzbot found the following issue on:
> 
> HEAD commit:    eb3ab13d997a net: ti: icssg_prueth: populate netdev of_node
> git tree:       net-next
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=17522ec5980000

#syz test net-next  eb3ab13d997a

--- x/net/vmw_vsock/vsock_bpf.c
+++ y/net/vmw_vsock/vsock_bpf.c
@@ -77,37 +77,29 @@ static int vsock_bpf_recvmsg(struct sock
 			     size_t len, int flags, int *addr_len)
 {
 	struct sk_psock *psock;
-	int copied;
+	int copied = -EAGAIN;
 
 	psock = sk_psock_get(sk);
 	if (unlikely(!psock))
-		return __vsock_recvmsg(sk, msg, len, flags);
+		return -EAGAIN;
 
 	lock_sock(sk);
-	if (vsock_has_data(sk, psock) && sk_psock_queue_empty(psock)) {
-		release_sock(sk);
-		sk_psock_put(sk, psock);
-		return __vsock_recvmsg(sk, msg, len, flags);
-	}
+	if (vsock_has_data(sk, psock) && sk_psock_queue_empty(psock))
+		goto out;
 
 	copied = sk_msg_recvmsg(sk, psock, msg, len, flags);
 	while (copied == 0) {
 		long timeo = sock_rcvtimeo(sk, flags & MSG_DONTWAIT);
 
-		if (!vsock_msg_wait_data(sk, psock, timeo)) {
-			copied = -EAGAIN;
+		copied = -EAGAIN;
+		if (!vsock_msg_wait_data(sk, psock, timeo))
+			break;
+		if (sk_psock_queue_empty(psock))
 			break;
-		}
-
-		if (sk_psock_queue_empty(psock)) {
-			release_sock(sk);
-			sk_psock_put(sk, psock);
-			return __vsock_recvmsg(sk, msg, len, flags);
-		}
-
 		copied = sk_msg_recvmsg(sk, psock, msg, len, flags);
 	}
 
+out:
 	release_sock(sk);
 	sk_psock_put(sk, psock);
 
--