linux-kernel - Re: [paulmckrcu:dev.2024.08.05a] [rcuscale] 0b85a3ea0a: WARNING:at_lib/alloc_tag.c:#alloc_tag_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZriCbCPF6I0JnbKi@xsang-OptiPlex-9020>
Date: Sun, 11 Aug 2024 17:20:44 +0800
From: Oliver Sang <oliver.sang@...el.com>
To: "paulmck@...nel.org" <paulmck@...nel.org>
CC: "oe-lkp@...ts.linux.dev" <oe-lkp@...ts.linux.dev>, lkp <lkp@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	<oliver.sang@...el.com>
Subject: Re: [paulmckrcu:dev.2024.08.05a] [rcuscale]  0b85a3ea0a:
 WARNING:at_lib/alloc_tag.c:#alloc_tag_module_unload

hi, Paul,

On Fri, Aug 09, 2024 at 09:44:40PM +0800, Paul E. McKenney wrote:

[...]

> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@...el.com>
> > | Closes: https://lore.kernel.org/oe-lkp/202408091019.8ed98238-lkp@intel.com
> > 
> > 
> > [  465.251143][ T1160] ------------[ cut here ]------------
> > [  465.252395][ T1160] kernel/rcu/rcuscale.c:1037 module rcuscale func:rcu_scale_init has 32 allocated at module unload
> > [ 465.252492][ T1160] WARNING: CPU: 0 PID: 1160 at lib/alloc_tag.c:170 alloc_tag_module_unload (lib/alloc_tag.c:168) 
> > [  465.256072][ T1160] Modules linked in: rcuscale(-) torture ipmi_devintf ppdev crct10dif_pclmul crc32_pclmul parport_pc aesni_intel parport serio_raw loop fuse [last unloaded: rcuscale]
> 
> Good catch, thank you!
> 
> Does the diff shown below help?

I applied below patch upon dev.2024.08.05a branch tip, which still has the
issue, confirmed the issue gone with your patch. thanks!


> 
> 							Thanx, Paul
> 
> ------------------------------------------------------------------------
> 
> diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c
> index b1c50df142eba..6d37596deb1f1 100644
> --- a/kernel/rcu/rcuscale.c
> +++ b/kernel/rcu/rcuscale.c
> @@ -1052,6 +1052,8 @@ rcu_scale_cleanup(void)
>  		writer_durations = NULL;
>  		kfree(writer_n_durations);
>  		writer_n_durations = NULL;
> +		kfree(writer_done);
> +		writer_done = NULL;
>  		kfree(writer_freelists);
>  		writer_freelists = NULL;
>  	}