linux-kernel - Re: [PATCH net-next] net: vxlan: remove duplicated initialization in vxlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240811135835.GK1951@kernel.org>
Date: Sun, 11 Aug 2024 14:58:35 +0100
From: Simon Horman <horms@...nel.org>
To: Menglong Dong <menglong8.dong@...il.com>
Cc: kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, idosch@...dia.com, amcohen@...dia.com,
	gnault@...hat.com, dongml2@...natelecom.cn, b.galvani@...il.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: vxlan: remove duplicated initialization in
 vxlan_xmit

On Sat, Aug 10, 2024 at 10:06:32AM +0800, Menglong Dong wrote:
> The variable "did_rsc" is initialized twice, which is unnecessary. Just
> remove one of them.
> 
> Signed-off-by: Menglong Dong <dongml2@...natelecom.cn>

Thanks, I have verified that did_rsc is initialised to false,
else where in this function, before it is otherwise used.

And, as the function may return before then, it does seem
reasonable to defer initialisation until then.

Reviewed-by: Simon Horman <horms@...nel.org>