linux-kernel - Re: [PATCH net-next v4 2/3] phy: Add Open Alliance helpers for the PHY framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ec9f6d52-b035-47f8-8ea5-afb50030406a@lunn.ch>
Date: Sun, 11 Aug 2024 17:33:30 +0200
From: Andrew Lunn <andrew@...n.ch>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Oleksij Rempel <o.rempel@...gutronix.de>,
	Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v4 2/3] phy: Add Open Alliance helpers for the
 PHY framework

On Sun, Aug 11, 2024 at 10:21:44AM +0100, Russell King (Oracle) wrote:
> On Sun, Aug 11, 2024 at 07:20:04AM +0200, Oleksij Rempel wrote:
> > diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile
> > index 202ed7f450da6..e93dfec881c5d 100644
> > --- a/drivers/net/phy/Makefile
> > +++ b/drivers/net/phy/Makefile
> > @@ -23,6 +23,7 @@ obj-$(CONFIG_MDIO_DEVRES)	+= mdio_devres.o
> >  libphy-$(CONFIG_SWPHY)		+= swphy.o
> >  libphy-$(CONFIG_LED_TRIGGER_PHY)	+= phy_led_triggers.o
> >  
> > +obj-$(CONFIG_OPEN_ALLIANCE_HELPERS) += open_alliance_helpers.o
> 
> I was thinking more
> libphy-$(CONFIG_OPEN_ALLIANCE_HELPERS) += open_alliance_helpers.o
> 
> rather than a potentially separate module.
> 
> If it is going to end up a separate module, then it needs its own
> MODULE_LICENSE, MODULE_DESCRIPTION, etc.

I'm happy either way.

	Andrew