linux-kernel - Re: [PATCH 1/2] selftests: rust: config: add trailing newline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4542b8cb-414c-49e3-8509-6975976ce3a6@linuxfoundation.org>
Date: Sun, 11 Aug 2024 17:36:50 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
 Anders Roxell <anders.roxell@...aro.org>
Cc: ojeda@...nel.org, alex.gaynor@...il.com, wedsonaf@...il.com,
 shuah@...nel.org, rust-for-linux@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 1/2] selftests: rust: config: add trailing newline

On 8/10/24 04:33, Miguel Ojeda wrote:
> On Fri, Aug 2, 2024 at 2:45 PM Anders Roxell <anders.roxell@...aro.org> wrote:
>>
>> If adding multiple config files to the merge_config.sh script and
>> rust/config is the fist one, then the last config fragment in this file
>> and the first config fragment in the second file wont be set, since
>> there isn't a newline in this file, so those two fragements end up at
>> the same row like:
>> CONFIG_SAMPLE_RUST_PRINT=mCONFIG_FRAGMENT=y
>>
>> And non of those will be enabled when running 'olddefconfig' after.
>>
>> Fixing the issue by adding a newline to the file.
> 
> Could `merge_config.sh` be improved too?
> 
> Shuah, if you plan to pick this:
> 
> Acked-by: Miguel Ojeda <ojeda@...nel.org>
> 
> Thanks!
> 
> Cheers,
> Miguel

Applied to linux-kselftest next for Linux 6.12-rc1.

thanks,
-- Shuah