linux-kernel - 答复: [PATCH v1] ALSA: usb-audio: Add delay quirk for VIVO USB-C-XE710 HEADSET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TYUPR06MB6217A8E5ABC66AECA2598F69D2842@TYUPR06MB6217.apcprd06.prod.outlook.com>
Date: Sun, 11 Aug 2024 04:19:55 +0000
From: 胡连勤 <hulianqin@...o.com>
To: Takashi Iwai <tiwai@...e.de>
CC: "perex@...ex.cz" <perex@...ex.cz>, "tiwai@...e.com" <tiwai@...e.com>,
	"mbarriolinares@...il.com" <mbarriolinares@...il.com>,
	"wangdicheng@...inos.cn" <wangdicheng@...inos.cn>, "sean@...s.org"
	<sean@...s.org>, "alexander@...y.me" <alexander@...y.me>,
	"xristos.thes@...il.com" <xristos.thes@...il.com>, "knuesel@...il.com"
	<knuesel@...il.com>, "linux-sound@...r.kernel.org"
	<linux-sound@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, opensource.kernel
	<opensource.kernel@...o.com>, "akpm@...ux-foundation.org"
	<akpm@...ux-foundation.org>
Subject:
 答复: [PATCH v1] ALSA: usb-audio: Add delay quirk for VIVO USB-C-XE710 HEADSET

From: Lianqin Hu <hulianqin@...o.com>

Audio control requests that sets sampling frequency sometimes fail on
this card. Adding delay between control messages eliminates that problem.

Signed-off-by: Lianqin Hu <hulianqin@...o.com>
---
v1:
  - Modify the code position and sort by ID
---
 sound/usb/quirks.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index ea063a14cdd8..e7b68c67852e 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -2221,6 +2221,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
 		   QUIRK_FLAG_GENERIC_IMPLICIT_FB),
 	DEVICE_FLG(0x2b53, 0x0031, /* Fiero SC-01 (firmware v1.1.0) */
 		   QUIRK_FLAG_GENERIC_IMPLICIT_FB),
+	DEVICE_FLG(0x2d95, 0x8021, /* VIVO USB-C-XE710 HEADSET */
+		   QUIRK_FLAG_CTL_MSG_DELAY_1M),
 	DEVICE_FLG(0x30be, 0x0101, /* Schiit Hel */
 		   QUIRK_FLAG_IGNORE_CTL_ERROR),
 	DEVICE_FLG(0x413c, 0xa506, /* Dell AE515 sound bar */
-- 
2.39.0


-----邮件原件-----
发件人: Takashi Iwai <tiwai@...e.de> 
发送时间: 2024年8月10日 16:45
收件人: 胡连勤 <hulianqin@...o.com>
抄送: perex@...ex.cz; tiwai@...e.com; mbarriolinares@...il.com; wangdicheng@...inos.cn; sean@...s.org; alexander@...y.me; xristos.thes@...il.com; knuesel@...il.com; linux-sound@...r.kernel.org; linux-kernel@...r.kernel.org; opensource.kernel <opensource.kernel@...o.com>; akpm@...ux-foundation.org
主题: Re: [PATCH] ALSA: usb-audio: Add delay quirk for VIVO USB-C-XE710 HEADSET

[You don't often get email from tiwai@...e.de. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

On Fri, 09 Aug 2024 12:38:52 +0200,
胡连勤 wrote:
>
> From: Lianqin Hu <hulianqin@...o.com>
>
> Audio control requests that sets sampling frequency sometimes fail on 
> this card. Adding delay between control messages eliminates that problem.
>
> Signed-off-by: Lianqin Hu <hulianqin@...o.com>
> ---
>  sound/usb/quirks.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index 
> ea063a14cdd8..4c7f0f9d15de 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -2119,6 +2119,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
>                  QUIRK_FLAG_GENERIC_IMPLICIT_FB),
>       DEVICE_FLG(0x07fd, 0x000b, /* MOTU M Series 2nd hardware revision */
>                  QUIRK_FLAG_CTL_MSG_DELAY_1M),
> +     DEVICE_FLG(0x2d95, 0x8021, /* VIVO USB-C-XE710 HEADSET */
> +                QUIRK_FLAG_CTL_MSG_DELAY_1M),
>       DEVICE_FLG(0x08bb, 0x2702, /* LineX FM Transmitter */
>                  QUIRK_FLAG_IGNORE_CTL_ERROR),
>       DEVICE_FLG(0x0951, 0x16ad, /* Kingston HyperX */

The quirk table entry is sorted in the ID number order.
Could you try to put the new entry at the right position?


thanks,

Takashi