linux-kernel - Re: [PATCH v1] scsi: ufs: core: introduce override_cqe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e0c2a00-1744-4cfd-b576-5efe74b21f9b@acm.org>
Date: Mon, 12 Aug 2024 10:12:01 -0700
From: Bart Van Assche <bvanassche@....org>
To: Bean Huo <huobean@...il.com>, Kiwoong Kim <kwmad.kim@...sung.com>,
 linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
 alim.akhtar@...sung.com, avri.altman@....com, jejb@...ux.ibm.com,
 martin.petersen@...cle.com, beanhuo@...ron.com, adrian.hunter@...el.com,
 h10.kim@...sung.com, hy50.seo@...sung.com, sh425.lee@...sung.com,
 kwangwon.min@...sung.com, junwoo80.lee@...sung.com, wkon.kim@...sung.com
Subject: Re: [PATCH v1] scsi: ufs: core: introduce override_cqe_ocs

On 8/12/24 8:41 AM, Bean Huo wrote:
> On Mon, 2024-08-12 at 16:01 +0900, Kiwoong Kim wrote:
>> +static inline enum utp_ocs ufshcd_vops_override_cqe_ocs(struct
>> ufs_hba *hba,
>> +                                                       enum utp_ocs
>> ocs)
>> +{
>> +       if (hba->vops && hba->vops->override_cqe_ocs)
>> +               return hba->vops->override_cqe_ocs(hba);
> 
> it is useless until you should introduce an usage case.

Indeed. If a new callback is introduced, a user for that callback should
be introduced in the same patch series.

Thanks,

Bart.