linux-kernel - Re: [PATCH] Documentation/llvm: turn make command for ccache into code block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240812190451.GA631776@thelio-3990X>
Date: Mon, 12 Aug 2024 12:04:51 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Nick Desaulniers <ndesaulniers@...gle.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>,
	Masahiro Yamada <masahiroy@...nel.org>,
	Nicolas Schier <nicolas@...sle.eu>,
	Jonathan Corbet <corbet@....net>, llvm@...ts.linux.dev,
	linux-kbuild@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Documentation/llvm: turn make command for ccache into
 code block

On Mon, Aug 12, 2024 at 02:17:21PM +0200, Javier Carrasco wrote:
> The command provided to use ccache with clang is not a literal code
> block. Once built, the documentation displays the '' symbols as a "
> character, which is wrong, and the command can not be applied as
> provided.
> 
> Turn the command into a literal code block.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>

Looks good to me.

Reviewed-by: Nathan Chancellor <nathan@...nel.org>

> ---
>  Documentation/kbuild/llvm.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/kbuild/llvm.rst b/Documentation/kbuild/llvm.rst
> index bb5c44f8bd1c..6dc66b4f31a7 100644
> --- a/Documentation/kbuild/llvm.rst
> +++ b/Documentation/kbuild/llvm.rst
> @@ -126,7 +126,7 @@ Ccache
>  
>  ``ccache`` can be used with ``clang`` to improve subsequent builds, (though
>  KBUILD_BUILD_TIMESTAMP_ should be set to a deterministic value between builds
> -in order to avoid 100% cache misses, see Reproducible_builds_ for more info):
> +in order to avoid 100% cache misses, see Reproducible_builds_ for more info)::
>  
>  	KBUILD_BUILD_TIMESTAMP='' make LLVM=1 CC="ccache clang"
>  
> 
> ---
> base-commit: 9e6869691724b12e1f43655eeedc35fade38120c
> change-id: 20240812-ccache-literal-code-block-8462614e91e9
> 
> Best regards,
> -- 
> Javier Carrasco <javier.carrasco.cruz@...il.com>
>