linux-kernel - Re: [PATCH] nfs: Remove unnecessary NULL check before kfree()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <B6F7413C-FCF5-441D-81E5-B08766CBC2FC@redhat.com>
Date: Mon, 12 Aug 2024 15:09:16 -0400
From: Benjamin Coddington <bcodding@...hat.com>
To: Thorsten Blum <thorsten.blum@...lux.com>
Cc: trondmy@...nel.org, anna@...nel.org, linux-nfs@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfs: Remove unnecessary NULL check before kfree()

On 11 Aug 2024, at 8:18, Thorsten Blum wrote:

> Since kfree() already checks if its argument is NULL, an additional
> check before calling kfree() is unnecessary and can be removed.
>
> Remove it and thus also the following Coccinelle/coccicheck warning
> reported by ifnullfree.cocci:
>
>   WARNING: NULL check before some freeing functions is not needed
>
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>

Correct, of course.

Reviewed-by: Benjamin Coddington <bcodding@...hat.com>

Ben