[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1a884b22-f73b-43af-9c1e-bb383936620a@lunn.ch>
Date: Mon, 12 Aug 2024 22:11:37 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Sean Anderson <sean.anderson@...ux.dev>
Cc: Radhey Shyam Pandey <radhey.shyam.pandey@....com>,
netdev@...r.kernel.org, Simon Horman <horms@...nel.org>,
Jakub Kicinski <kuba@...nel.org>,
Russell King <linux@...linux.org.uk>,
"David S . Miller" <davem@...emloft.net>,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
Paolo Abeni <pabeni@...hat.com>,
Michal Simek <michal.simek@....com>,
Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next v2 1/2] net: xilinx: axienet: Report RxRject as
rx_dropped
On Mon, Aug 12, 2024 at 01:41:17PM -0400, Sean Anderson wrote:
> The Receive Frame Rejected interrupt is asserted whenever there was a
> receive error (bad FCS, bad length, etc.) or whenever the frame was
> dropped due to a mismatched address. So this is really a combination of
> rx_otherhost_dropped, rx_length_errors, rx_frame_errors, and
> rx_crc_errors. Mismatched addresses are common and aren't really errors
> at all (much like how fragments are normal on half-duplex links). To
> avoid confusion, report these events as rx_dropped. This better
> reflects what's going on: the packet was received by the MAC but dropped
> before being processed.
>
> Signed-off-by: Sean Anderson <sean.anderson@...ux.dev>
Reviewed-by: Andrew Lunn <andrew@...n.ch>
Andrew
Powered by blists - more mailing lists