linux-kernel - Re: [PATCH net v2] selftest: af_unix: Fix kselftest compilation warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240812201306.70769-1-kuniyu@amazon.com>
Date: Mon, 12 Aug 2024 13:13:06 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <jain.abhinav177@...il.com>
CC: <davem@...emloft.net>, <edumazet@...gle.com>,
	<javier.carrasco.cruz@...il.com>, <kuba@...nel.org>,
	<linux-kernel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
	<netdev@...r.kernel.org>, <pabeni@...hat.com>, <shuah@...nel.org>,
	<skhan@...uxfoundation.org>, <kuniyu@...zon.com>
Subject: Re: [PATCH net v2] selftest: af_unix: Fix kselftest compilation warnings

From: Abhinav Jain <jain.abhinav177@...il.com>
Date: Tue, 13 Aug 2024 00:41:22 +0530
> Change the parameter expected_buf from (const void *) to (const char *)
> in the function __recvpair() as per the feedback in v1.
> Add Fixes tag as per feedback in v1.
> 
> This change fixes the below warnings during test compilation:
> 
> ```
> In file included from msg_oob.c:14:
> msg_oob.c: In function ‘__recvpair’:
> 
> ../../kselftest_harness.h:106:40: warning: format ‘%s’ expects argument
> of type ‘char *’,but argument 6 has type ‘const void *’ [-Wformat=]
> 
> ../../kselftest_harness.h:101:17: note: in expansion of macro ‘__TH_LOG’
> msg_oob.c:235:17: note: in expansion of macro ‘TH_LOG’
> 
> ../../kselftest_harness.h:106:40: warning: format ‘%s’ expects argument
> of type ‘char *’,but argument 6 has type ‘const void *’ [-Wformat=]
> 
> ../../kselftest_harness.h:101:17: note: in expansion of macro ‘__TH_LOG’
> msg_oob.c:259:25: note: in expansion of macro ‘TH_LOG’
> ```
> 
> v1:
> lore.kernel.org/netdev/20240810134037.669765-1-jain.abhinav177@...il.com
> 
> Fixes: d098d77232c3 ("selftest: af_unix: Add msg_oob.c.")
> Signed-off-by: Abhinav Jain <jain.abhinav177@...il.com>

No need to respin, but a minor comment below for the future patches.

Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>

> ---

You can put changelog between revisions after "---" so that it will
disappear during merge.

And, it would be easy to jump to v1 if it has https:// .

Here's a nice example:

https://docs.kernel.org/process/maintainer-netdev.html#changes-requested

Thanks!