linux-kernel - Re: [PATCH v1] perf inject: Fix leader sampling inserting additional samples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zrp1vxhQMOSoBQnZ@x1>
Date: Mon, 12 Aug 2024 17:51:11 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>, linux-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH v1] perf inject: Fix leader sampling inserting additional
 samples

On Mon, Aug 12, 2024 at 01:37:36PM -0700, Ian Rogers wrote:
> On Wed, Jul 31, 2024 at 11:21 AM Namhyung Kim <namhyung@...nel.org> wrote:
> > > This behavior is incorrect as in the case above perf inject should
> > > have done nothing. Fix this behavior by disabling separating samples
> > > for a tool that requests it. Only request this for `perf inject` so as
> > > to not affect other perf tools. With the patch and the test above
> > > there are no differences between the orig.txt and new.txt.

> > > Fixes: e4caec0d1af3 ("perf evsel: Add PERF_SAMPLE_READ sample related processing")
> > > Signed-off-by: Ian Rogers <irogers@...gle.com>

> > Acked-by: Namhyung Kim <namhyung@...nel.org>

> Ping.

Thanks, applied to perf-tools-next,

- Arnaldo