lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ae818694-e697-41cc-a731-73cd50dd7d99@lunn.ch>
Date: Mon, 12 Aug 2024 23:27:59 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, linux@...linux.org.uk,
	linux-kernel@...r.kernel.org, o.rempel@...gutronix.de
Subject: Re: [PATCH net-next 2/3] net: ag71xx: use devm for
 of_mdiobus_register

On Mon, Aug 12, 2024 at 12:06:52PM -0700, Rosen Penev wrote:
> Allows removing ag71xx_mdio_remove.
> 
> Removed local mii_bus variable and assign struct members directly.
> Easier to reason about.

This mixes up two different things, making the patch harder to
review. Ideally you want lots of little patches, each doing one thing,
and being obviously correct. 

Is ag->mii_bus actually used anywhere, outside of ag71xx_mdio_probe()?
Often swapping to devm_ means the driver does not need to keep hold of
the resources. So i actually think you can remove ag->mii_bus. This
might of been more obvious if you had first swapped to
devm_of_mdiobus_register() without the other changes mixed in.

    Andrew

---
pw-bot: cr

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ