linux-kernel - Re: [PATCH 1/1] x86/ioremap: Use is_vmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZrmoZKI1UHRRln7j@infradead.org>
Date: Sun, 11 Aug 2024 23:15:00 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Alistair Popple <apopple@...dia.com>
Cc: Max Ramanouski <max8rr8@...il.com>, x86@...nel.org,
	dave.hansen@...ux.intel.com, luto@...nel.org, peterz@...radead.org,
	linux-kernel@...r.kernel.org, jniethe@...dia.com,
	jhubbard@...dia.com, linux-mm@...ck.org, tglx@...utronix.de
Subject: Re: [PATCH 1/1] x86/ioremap: Use is_vmalloc_addr in iounmap

(Somehow I can't find the original in my inbox, so replying here).

The correct helper to use is is_ioremap_addr, as in the generic
iounmap implementation.  This won't matter for x86 currently, but
it clearly documents what the code is doing.

More long term, but I really hate how x86 is not using more of the
generic ioremap code.  kmsan_iounmap_page_range should really move
to generic_iounmap, as should memtype_free after adding a properly
stubbed out API for it.

With that x86 iounmap would just contain a hook for the magic
ISA region, the mmio trace call and then call into generic_ioremap
and we'd get rid of these open coded checks.