linux-kernel - Re: [PATCH v6 0/4 RESEND] media: mgb4: YUV and variable framerate support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4f6f76a-0bad-4629-b438-a048ee683123@xs4all.nl>
Date: Mon, 12 Aug 2024 08:53:03 +0200
From: Hans Verkuil <hverkuil@...all.nl>
To: tumic@...see.org, Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 Martin Tůma <martin.tuma@...iteqautomotive.com>
Subject: Re: [PATCH v6 0/4 RESEND] media: mgb4: YUV and variable framerate
 support

Hi Martin,

Before I merge this series, I would like to see the v4l2-compliance output for
each video device.

Can you reply with that output?

I want to make sure that all the g/s_parm and dv_timings changes are correct
according to v4l2-compliance. And of course, if it isn't, then please fix
any reported issue and post a v7.

Regards,

	Hans

On 05/08/2024 17:40, tumic@...see.org wrote:
> From: Martin Tůma <martin.tuma@...iteqautomotive.com>
> 
> Recent mgb4 FW update added support for the YUV image format and variable
> framerates independent of the signal framerate. The following patches extend
> the mgb4 driver with support for both features.
> 
> Changes in V6:
> - Properly handle the timings when no signal is present.
> 
> Changes in V5:
> - Removed surplus v4l2_format.type checks.
> - Improved the patch descriptions.
> - Splitted the frame rate limit patch into separate code/documentation parts.
> 
> Changes in V4:
> - Splitted the output frame_rate handling fix from the variable frame rate
>   addition patch.
> 
> Changes in V3:
> - Use div_u64() for 64b division (fixes build error on ARM32)
> 
> Changes in V2:
> - Added missing stride limit
> 
> Martin Tůma (4):
>   media: mgb4: Add support for YUV image formats
>   media: mgb4: Add support for V4L2_CAP_TIMEPERFRAME
>   media: mgb4: Fixed signal frame rate limit handling
>   media: admin-guide: mgb4: Outputs DV timings documentation update
> 
>  Documentation/admin-guide/media/mgb4.rst |  23 +-
>  drivers/media/pci/mgb4/mgb4_core.c       |   2 +-
>  drivers/media/pci/mgb4/mgb4_core.h       |   2 +
>  drivers/media/pci/mgb4/mgb4_io.h         |  29 ++-
>  drivers/media/pci/mgb4/mgb4_sysfs_out.c  |   9 +-
>  drivers/media/pci/mgb4/mgb4_vin.c        | 193 +++++++++++---
>  drivers/media/pci/mgb4/mgb4_vin.h        |   3 +-
>  drivers/media/pci/mgb4/mgb4_vout.c       | 309 ++++++++++++++++++++---
>  drivers/media/pci/mgb4/mgb4_vout.h       |   5 +-
>  9 files changed, 482 insertions(+), 93 deletions(-)
> 
> 
> base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0