[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ebbdf2e9-932f-4a7c-9c6e-3c8c80a3b524@bootlin.com>
Date: Mon, 12 Aug 2024 09:22:54 +0200
From: Alexis Lothoré <alexis.lothore@...tlin.com>
To: Martin KaFai Lau <martin.lau@...ux.dev>
Cc: Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>,
Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>,
Yonghong Song <yonghong.song@...ux.dev>,
John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,
Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>,
Jiri Olsa <jolsa@...nel.org>, Mykola Lysenko <mykolal@...com>,
Shuah Khan <shuah@...nel.org>, ebpf@...uxfoundation.org,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
linux-kernel@...r.kernel.org, bpf@...r.kernel.org,
linux-kselftest@...r.kernel.org
Subject: Re: [PATCH bpf-next v2 4/4] selftests/bpf: convert
test_skb_cgroup_id_user to test_progs
Hello Martin,
On 8/10/24 01:53, Martin KaFai Lau wrote:
> On 8/6/24 12:55 AM, Alexis Lothoré (eBPF Foundation) wrote:
[...]
>> + SYS(fail, "ip link add dev %s type veth peer name %s", VETH_1, VETH_2);
>> + SYS(fail, "ip link set %s up", VETH_1);
>> + SYS(fail, "ip link set %s up", VETH_2);
>
> Same. Do it under a new netns.
>
>> +
[...]
>> + if (setup_network(&t))
>> + goto cleanup_progs;
>> +
>> + cgroup_fd = cgroup_setup_and_join(CGROUP_PATH);
>
> cgroup_fd is leaked.
ACK, I will prepare a new revision with all the leaked file descriptors you have
spotted fixed, and with tests performed in a dedicated netns.
> Thanks for working on this.
Thanks for the review !
Alexis
--
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Powered by blists - more mailing lists