linux-kernel - Re: [PATCH] ALSA: hda/realtek: tas2781: Fix ROG ALLY X audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87frra2ocp.wl-tiwai@suse.de>
Date: Mon, 12 Aug 2024 09:26:46 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Jonathan LoBue <jlobue10@...il.com>
Cc: perex@...ex.cz,
	tiwai@...e.com,
	shenghao-ding@...com,
	kailang@...ltek.com,
	alsa-devel@...a-project.org,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	derekjohn.clark@...il.com,
	luke@...nes.dev,
	benato.denis96@...il.com,
	Kyle Gospodnetich <me@...egospodneti.ch>,
	Jan Drogehoff <sentrycraft123@...il.com>,
	Antheas Kapenekakis <lkml@...heas.dev>,
	Richard Alvarez <alvarez.richard@...il.com>,
	Miles Montierth <cyber_dopamine@...heblackmedia.com>
Subject: Re: [PATCH] ALSA: hda/realtek: tas2781: Fix ROG ALLY X audio

On Mon, 12 Aug 2024 06:53:25 +0200,
Jonathan LoBue wrote:
> 
> This patch enables the TI TAS2781 amplifier SoC for the ASUS ROG ALLY X.
> This is a design change from the original ASUS ROG ALLY, creating the need
> for this patch. All other Realtek Codec settings seem to be re-used from
> the original ROG ALLY design (on the ROG ALLY X). This patch maintains the
> previous settings for the Realtek codec portion, but enables the I2C
> binding for the TI TAS2781 amplifier (instead of the Cirrus CS35L41 amp
> used on the original ASUS ROG ALLY).
> 
> One other requirement must be met for audio to work on the ASUS ROG ALLY X.
> A proper firmware file in the correct location with a proper symlink. We
> had reached out to TI engineers and confirmed that the firmware found in
> the Windows' driver package has a GPL license. Bazzite Github is hosting
> this firmware file for now until proper linux-firmware upstreaming can
> occur. https://github.com/ublue-os/bazzite
> 
> This firmware file should be placed in
> /usr/lib/firmware/ti/tas2781/TAS2XXX1EB3.bin with a symlink to it from
> /usr/lib/firmware/TAS2XXX1EB3.bin
> 
> Co-developed by: Kyle Gospodnetich <me@...egospodneti.ch>
> Signed-off-by: Kyle Gospodnetich <me@...egospodneti.ch>
> Co-developed by: Jan Drogehoff <sentrycraft123@...il.com>
> Signed-off-by: Jan Drogehoff <sentrycraft123@...il.com>
> Signed-off-by: Antheas Kapenekakis <lkml@...heas.dev>
> Tested-by: Richard Alvarez <alvarez.richard@...il.com>
> Tested-by: Miles Montierth <cyber_dopamine@...heblackmedia.com>
> Signed-off-by: Jonathan LoBue <jlobue10@...il.com>

Applied to for-next branch.

Meanwhile, could you ask TI guys to include the missing firmware files
in linux-firmware git tree, too?


thanks,

Takashi