linux-kernel - Re: [PATCH v2 4/6] platform/x86: asus-armoury: add apu-mem control support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a663ee3e-1c8b-5e7d-503f-e46641039f16@linux.intel.com>
Date: Mon, 12 Aug 2024 10:39:47 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Luke Jones <luke@...nes.dev>
cc: platform-driver-x86@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, 
    Hans de Goede <hdegoede@...hat.com>, corentin.chary@...il.com
Subject: Re: [PATCH v2 4/6] platform/x86: asus-armoury: add apu-mem control
 support

On Sun, 11 Aug 2024, Luke Jones wrote:

> On Tue, 6 Aug 2024, at 10:20 PM, Ilpo Järvinen wrote:
> > On Tue, 6 Aug 2024, Luke D. Jones wrote:
> > 
> > > Implement the APU memory size control under the asus-armoury module using
> > > the fw_attributes class.
> > > 
> > > This allows the APU allocated memory size to be adjusted depending on
> > > the users priority. A reboot is required after change.
> > > 
> > > Signed-off-by: Luke D. Jones <luke@...nes.dev>
> > > ---

> > > + sysfs_notify(kobj, NULL, attr->attr.name);
> > > +
> > > + asus_set_reboot_and_signal_event();
> > > +
> > > + return count;
> > > +}
> > > +
> > > +static ssize_t apu_mem_possible_values_show(struct kobject *kobj,
> > > + struct kobj_attribute *attr, char *buf)
> > > +{
> > > + return sysfs_emit(buf, "0;1;2;3;4;5;6;7;8\n");
> 
> Ack all
> 
> > IIRC, space or newline is the usual separator for possible values sysfs 
> > files. I don't think I've ever seen ; used.
> 
> The docs specify this format. https://github.com/torvalds/linux/blob/5189dafa4cf950e675f02ee04b577dfbbad0d9b1/Documentation/ABI/testing/sysfs-class-firmware-attributes#L56

Okay, I didn't know. Please use what's documented then.

-- 
 i.