lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240812094621.1f4954d4@xps-13>
Date: Mon, 12 Aug 2024 09:46:21 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Keguang Zhang <keguang.zhang@...il.com>
Cc: Keguang Zhang via B4 Relay <devnull+keguang.zhang.gmail.com@...nel.org>,
 Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
 linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-mips@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v7 3/3] mtd: rawnand: Add Loongson-1 NAND Controller
 driver

Hi Keguang,

> > > +
> > > +                     nfc->data->parse_address(chip, addrs, naddrs, cmd);
> > > +                     /* set NAND address */
> > > +                     nand_writel(nfc, NAND_ADDR1, nfc->addr1_reg);
> > > +                     nand_writel(nfc, NAND_ADDR2, nfc->addr2_reg);
> > > +                     break;
> > > +             case NAND_OP_DATA_IN_INSTR:
> > > +             case NAND_OP_DATA_OUT_INSTR:
> > > +                     offset = nand_subop_get_data_start_off(subop, op_id);
> > > +                     nfc->len = nand_subop_get_data_len(subop, op_id);
> > > +                     if (instr->type == NAND_OP_DATA_IN_INSTR)
> > > +                             nfc->buf =
> > > +                                 (void *)instr->ctx.data.buf.in + offset;
> > > +                     else if (instr->type == NAND_OP_DATA_OUT_INSTR)
> > > +                             nfc->buf =
> > > +                                 (void *)instr->ctx.data.buf.out + offset;  
> >
> > The buf pointer feels clunky. You don't know for how long the buffer
> > you point to will be valid, please don't do that.
> >  
> The buf pointer is used for DMA transfer afterwards.
> I referred to other drivers, and they used the same approach.
> https://elixir.bootlin.com/linux/v6.8.9/source/drivers/mtd/nand/raw/arasan-nand-controller.c#L647

nfc_op is a local variable, it doesn't live past the function call.

> https://elixir.bootlin.com/linux/v6.8.9/source/drivers/mtd/nand/raw/rockchip-nand-controller.c#L366

Thanks,
Miquèl

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ