linux-kernel - Re: [PATCH 1/4] mm: Add optional close() to struct vm_special

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h6bq880b.fsf@mail.lhotse>
Date: Mon, 12 Aug 2024 18:23:16 +1000
From: Michael Ellerman <mpe@...erman.id.au>
To: David Hildenbrand <david@...hat.com>, linux-mm@...ck.org
Cc: linuxppc-dev@...ts.ozlabs.org, torvalds@...ux-foundation.org,
 akpm@...ux-foundation.org, christophe.leroy@...roup.eu,
 jeffxu@...omium.org, jeffxu@...gle.com, Liam.Howlett@...cle.com,
 linux-kernel@...r.kernel.org, npiggin@...il.com, oliver.sang@...el.com,
 pedro.falcato@...il.com
Subject: Re: [PATCH 1/4] mm: Add optional close() to struct vm_special_mapping

David Hildenbrand <david@...hat.com> writes:
> On 07.08.24 14:41, Michael Ellerman wrote:
>> Add an optional close() callback to struct vm_special_mapping. It will
>> be used, by powerpc at least, to handle unmapping of the VDSO.
>> 
>> Suggested-by: Linus Torvalds <torvalds@...ux-foundation.org>
>> Signed-off-by: Michael Ellerman <mpe@...erman.id.au>
>> ---
>>   include/linux/mm_types.h | 2 ++
>>   mm/mmap.c                | 3 +++
>>   2 files changed, 5 insertions(+)
>> 
>> diff --git a/mm/mmap.c b/mm/mmap.c
>> index d0dfc85b209b..24bd6aa9155c 100644
>> --- a/mm/mmap.c
>> +++ b/mm/mmap.c
>> @@ -3624,6 +3624,9 @@ static vm_fault_t special_mapping_fault(struct vm_fault *vmf);
>>    */
>>   static void special_mapping_close(struct vm_area_struct *vma)
>>   {
>> +	const struct vm_special_mapping *sm = vma->vm_private_data;
>
> I'm old-fashioned, I enjoy an empty line here ;)

Ack.

>> +	if (sm->close)
>> +		sm->close(sm, vma);
>
> Reviewed-by: David Hildenbrand <david@...hat.com>

Thanks.

cheers