linux-kernel - Re: [Bug report] NFS patch breaks TLS device-offloaded TX zerocopy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240812090215.GA5497@lst.de>
Date: Mon, 12 Aug 2024 11:02:15 +0200
From: Christoph Hellwig <hch@....de>
To: Tariq Toukan <ttoukan.linux@...il.com>
Cc: Sagi Grimberg <sagi@...mberg.me>, Christoph Hellwig <hch@....de>,
	Anna Schumaker <Anna.Schumaker@...app.com>,
	Trond Myklebust <trondmy@...nel.org>, linux-nfs@...r.kernel.org,
	Boris Pismenny <borisp@...dia.com>,
	John Fastabend <john.fastabend@...il.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Maxim Mikityanskiy <maxtram95@...il.com>,
	Saeed Mahameed <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>,
	Networking <netdev@...r.kernel.org>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Leon Romanovsky <leon@...nel.org>, Tariq Toukan <tariqt@...dia.com>
Subject: Re: [Bug report] NFS patch breaks TLS device-offloaded TX zerocopy

On Tue, Aug 06, 2024 at 01:07:47PM +0300, Tariq Toukan wrote:
> Adding Maxim Mikityanskiy, he might have some insights.

I think the important part to find out is if the in-kernel TLS API
has a limitation to PAGE_SIZE buffer segments, or not.  If it does
we need to disable large folios for the in-kernel consumers of the
API, which is easy (but annoying) for NFS that trigger this, but quite
painful for NVMe.  Or the API is supposed to handle it and just this
one offload gets it wrong, in which case we need to fix it.