linux-kernel - Re: [PATCH] kselftest/cgroup: Add missing newline in test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7612504c-cd56-4fcd-a287-d3fbc89162ea@linuxfoundation.org>
Date: Mon, 12 Aug 2024 03:35:23 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Mohammed Anees <pvmohammedanees2003@...il.com>, hannes@...xchg.org,
 yosryahmed@...gle.com, nphamcs@...il.com, chengming.zhou@...ux.dev,
 tj@...nel.org, lizefan.x@...edance.com, mkoutny@...e.com, shuah@...nel.org
Cc: linux-mm@...ck.org, cgroups@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] kselftest/cgroup: Add missing newline in test_zswap.c

On 8/11/24 08:58, Mohammed Anees wrote:

Missing change log

> Signed-off-by: Mohammed Anees <pvmohammedanees2003@...il.com>
> ---
>   tools/testing/selftests/cgroup/test_zswap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/cgroup/test_zswap.c b/tools/testing/selftests/cgroup/test_zswap.c
> index 190096017..7c849d836 100644
> --- a/tools/testing/selftests/cgroup/test_zswap.c
> +++ b/tools/testing/selftests/cgroup/test_zswap.c
> @@ -351,7 +351,7 @@ static int test_zswap_writeback(const char *root, bool wb)
>   		goto out;
>   
>   	if (wb != !!zswpwb_after) {
> -		ksft_print_msg("zswpwb_after is %ld while wb is %s",
> +		ksft_print_msg("zswpwb_after is %ld while wb is %s\n",
>   				zswpwb_after, wb ? "enabled" : "disabled");
>   		goto out;
>   	}

The change looks good to me.

Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah