linux-kernel - Re: [PATCH net v1] mlxbf_gige: disable RX filters until RX path initialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240812102426.GB468359@kernel.org>
Date: Mon, 12 Aug 2024 11:24:26 +0100
From: Simon Horman <horms@...nel.org>
To: David Thompson <davthompson@...dia.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, leon@...nel.org, yuehaibing@...wei.com,
	andriy.shevchenko@...ux.intel.com, u.kleine-koenig@...gutronix.de,
	asmaa@...dia.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v1] mlxbf_gige: disable RX filters until RX path
 initialized

On Fri, Aug 09, 2024 at 12:36:12PM -0400, David Thompson wrote:
> A recent change to the driver exposed a bug where the MAC RX
> filters (unicast MAC, broadcast MAC, and multicast MAC) are
> configured and enabled before the RX path is fully initialized.
> The result of this bug is that after the PHY is started packets
> that match these MAC RX filters start to flow into the RX FIFO.
> And then, after rx_init() is completed, these packets will go
> into the driver RX ring as well. If enough packets are received
> to fill the RX ring (default size is 128 packets) before the call
> to request_irq() completes, the driver RX function becomes stuck.
> 
> This bug is intermittent but is most likely to be seen where the
> oob_net0 interface is connected to a busy network with lots of
> broadcast and multicast traffic.
> 
> All the MAC RX filters must be disabled until the RX path is ready,
> i.e. all initialization is done and all the IRQs are installed.
> 
> Fixes: f7442a634ac0 ("mlxbf_gige: call request_irq() after NAPI initialized")
> Reviewed-by: Asmaa Mnebhi <asmaa@...dia.com>
> Signed-off-by: David Thompson <davthompson@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>