linux-kernel - Re: [PATCH 2/3] crypto: api - Do not wait for tests during registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zrnk6Y8IDxmN99kG@gondor.apana.org.au>
Date: Mon, 12 Aug 2024 18:33:13 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: oe-kbuild@...ts.linux.dev,
	Linus Torvalds <torvalds@...ux-foundation.org>, lkp@...el.com,
	oe-kbuild-all@...ts.linux.dev, LKML <linux-kernel@...r.kernel.org>,
	"Russell King (Oracle)" <linux@...linux.org.uk>,
	Horia Geantă <horia.geanta@....com>,
	Ard Biesheuvel <ardb@...nel.org>, linux-crypto@...r.kernel.org
Subject: Re: [PATCH 2/3] crypto: api - Do not wait for tests during
 registration

On Sun, Aug 11, 2024 at 04:30:10PM +0300, Dan Carpenter wrote:
>
> c72358571aaadf Karim Eshapa   2017-05-13  368  	pr_err("alg: Unexpected test result for %s: %d\n", name, err);
> 73d3864a4823ab Herbert Xu     2008-08-03  369  	goto unlock;
> 
> This calling crypto_alg_put() on the last item in the list seems wrong either
> way.

Indeed.  This should just return.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt