linux-kernel - Re: [PATCH net-next v4 5/5] net: dsa: microchip: apply KSZ87xx family fixes wrt datasheet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e93d13b451a263470e93706faa3afbfe2b5cd57b.camel@microchip.com>
Date: Mon, 12 Aug 2024 10:45:50 +0000
From: <Arun.Ramadoss@...rochip.com>
To: <andrew@...n.ch>, <olteanv@...il.com>, <davem@...emloft.net>,
	<linux@...linux.org.uk>, <conor+dt@...nel.org>, <Woojung.Huh@...rochip.com>,
	<robh@...nel.org>, <krzk+dt@...nel.org>, <f.fainelli@...il.com>,
	<kuba@...nel.org>, <vtpieter@...il.com>, <UNGLinuxDriver@...rochip.com>,
	<marex@...x.de>, <edumazet@...gle.com>, <pabeni@...hat.com>
CC: <pieter.van.trappen@...n.ch>, <devicetree@...r.kernel.org>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v4 5/5] net: dsa: microchip: apply KSZ87xx family
 fixes wrt datasheet

Hi Pieter, 



@@ -141,7 +141,7 @@ static struct sk_buff *ksz8795_rcv(struct sk_buff
> *skb, struct net_device *dev)
>  {
>         u8 *tag = skb_tail_pointer(skb) - KSZ_EGRESS_TAG_LEN;
> 
> -       return ksz_common_rcv(skb, dev, tag[0] & 7,
> KSZ_EGRESS_TAG_LEN);
> +       return ksz_common_rcv(skb, dev, tag[0] & 3,
> KSZ_EGRESS_TAG_LEN);
>  }

This change can be separate patch. since it is not related to
ksz87xx_dev_ops structure. Is it a fix or just good to have one. If it
is a fix then it should be point to net tree. 

> 
>  static const struct dsa_device_ops ksz8795_netdev_ops = {
> --
> 2.43.0
>